Repository navigation
V-3523 switch spree branch to 5-6-stable - #59
Conversation
Strix Security ReviewNo security issues found. Updated for Reviewed by Strix |
WalkthroughThe PR updates the Spree GitHub dependency from the ChangesSpree 5-6-stable upgrade
Estimated code review effort: 1 (Trivial) | ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Gemfile (1)
19-19: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winMove
spree_custom_domainsbeforespree_multi_store.Keep gems alphabetically ordered within the Spree section. This satisfies RuboCop
Bundler/OrderedGems.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Gemfile` at line 19, Move the spree_custom_domains dependency before spree_multi_store in the Spree section of the Gemfile, preserving alphabetical ordering required by Bundler/OrderedGems.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@Gemfile`:
- Line 19: Move the spree_custom_domains dependency before spree_multi_store in
the Spree section of the Gemfile, preserving alphabetical ordering required by
Bundler/OrderedGems.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: c768536b-63a5-4abf-9eee-36735f81e747
📒 Files selected for processing (2)
Gemfilespec/models/spree_adyen/payment_session_spec.rb
| gem 'spree_admin', spree_opts | ||
|
|
||
| gem 'spree_multi_store' | ||
| gem 'spree_custom_domains' |
There was a problem hiding this comment.
In Spree 5.6, custom-domain functionality was extracted out of spree_multi_store into a new standalone spree_custom_domains gem
Note
Medium Risk
Moving off Spree main to a stable branch plus a new extension affects the whole commerce stack; the spec change only reflects tighter payment validation in that release line.
Overview
Pins Spree to the
5-6-stablebranch instead ofmainforspreeandspree_adminGitHub dependencies, and adds thespree_custom_domainsgem alongside the existing Spree extension stack.Updates
payment_session_specso completed payments are built with an explicit store-scoped credit card payment method, keeping amount-cap validation examples valid under the stricter payment associations in 5-6-stable.Reviewed by Cursor Bugbot for commit 2ffbfb7. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit