Skip to content

V-3523 switch spree branch to 5-6-stable - #59

Merged
KacperMekarski merged 2 commits into
mainfrom
V-3523
Aug 4, 2026
Merged

KacperMekarski merged 2 commits into
mainfrom
V-3523

Conversation

@KacperMekarski

@KacperMekarski KacperMekarski commented Aug 4, 2026 •

Copy link
Copy Markdown
Contributor

Note

Medium Risk
Moving off Spree main to a stable branch plus a new extension affects the whole commerce stack; the spec change only reflects tighter payment validation in that release line.

Overview
Pins Spree to the 5-6-stable branch instead of main for spree and spree_admin GitHub dependencies, and adds the spree_custom_domains gem alongside the existing Spree extension stack.

Updates payment_session_spec so completed payments are built with an explicit store-scoped credit card payment method, keeping amount-cap validation examples valid under the stricter payment associations in 5-6-stable.

Reviewed by Cursor Bugbot for commit 2ffbfb7. Bugbot is set up for automated code reviews on this repo. Configure here.

Summary by CodeRabbit

  • Chores
    • Updated the Spree platform to the stable 5-6 release line.
    • Added support for custom domains.

@strix-security

strix-security Bot commented Aug 4, 2026 •

Copy link
Copy Markdown

Strix Security Review

No security issues found.

Updated for f0a30f0.


Reviewed by Strix
Re-run review · Configure security review settings

@coderabbitai

coderabbitai Bot commented Aug 4, 2026 •

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The PR updates the Spree GitHub dependency from the main branch to 5-6-stable and adds the spree_custom_domains gem. A payment session test is updated to use a store-associated credit-card payment method.

Changes

Spree 5-6-stable upgrade

Layer / File(s) Summary
Update Spree dependencies
Gemfile
The Spree GitHub dependency now tracks the 5-6-stable branch instead of main. The spree_custom_domains gem is added.
Update payment method test fixture
spec/models/spree_adyen/payment_session_spec.rb
The payment session test creates and uses a store-associated credit-card payment method instead of the default payment factory method.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Poem

A rabbit hops to stable ground,
Where 5-6 branches can be found.
A gem joins in, a test gets care,
All changes small but placed with flair. 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: switching the Spree dependency branch to 5-6-stable.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch V-3523

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
Gemfile (1)

19-19: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Move spree_custom_domains before spree_multi_store.

Keep gems alphabetically ordered within the Spree section. This satisfies RuboCop Bundler/OrderedGems.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Gemfile` at line 19, Move the spree_custom_domains dependency before
spree_multi_store in the Spree section of the Gemfile, preserving alphabetical
ordering required by Bundler/OrderedGems.

Source: Linters/SAST tools

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@Gemfile`:
- Line 19: Move the spree_custom_domains dependency before spree_multi_store in
the Spree section of the Gemfile, preserving alphabetical ordering required by
Bundler/OrderedGems.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c768536b-63a5-4abf-9eee-36735f81e747

📥 Commits

Reviewing files that changed from the base of the PR and between f0a30f0 and 2ffbfb7.

📒 Files selected for processing (2)
  • Gemfile
  • spec/models/spree_adyen/payment_session_spec.rb

Comment thread Gemfile
gem 'spree_admin', spree_opts

gem 'spree_multi_store'
gem 'spree_custom_domains'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Spree 5.6, custom-domain functionality was extracted out of spree_multi_store into a new standalone spree_custom_domains gem

@KacperMekarski
KacperMekarski requested a review from mad-eel August 4, 2026 12:08
@KacperMekarski
KacperMekarski merged commit ff01b5a into main Aug 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants