This repository was archived by the owner on Apr 11, 2026. It is now read-only.
Fix @McpResource title not propagated to Resource/ResourceTemplate#108
Open
mzeijen wants to merge 1 commit intospring-ai-community:mainfrom
Open
Fix @McpResource title not propagated to Resource/ResourceTemplate#108mzeijen wants to merge 1 commit intospring-ai-community:mainfrom
mzeijen wants to merge 1 commit intospring-ai-community:mainfrom
Conversation
The title attribute from @McpResource was never read or passed to the McpSchema.Resource and McpSchema.ResourceTemplate builders in all four resource provider classes and in ResourceAdapter.asResourceTemplate(). This caused the title to always be null in the built objects. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
@McpResourceannotation has atitleattribute, but none of the resource provider classes (AsyncMcpResourceProvider,AsyncStatelessMcpResourceProvider,SyncMcpResourceProvider,SyncStatelessMcpResourceProvider) copied it into theMcpSchema.ResourceorMcpSchema.ResourceTemplateobjects they build. Additionally,ResourceAdapter.asResourceTemplate()was missing the.title()call (whileasResource()already had it).For example, given:
After building via any resource provider's
getResourceSpecifications():resource.title()wasnull(expected:"My Resource Title")This PR fixes the issue by reading
resourceAnnotation.title()and passing it to.title()on bothMcpSchema.ResourceandMcpSchema.ResourceTemplatebuilders in all four provider classes and inResourceAdapter.asResourceTemplate().