Skip to content

Optimize ThreadLocalScopeCache #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optimize ThreadLocalScopeCache #1108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...t/src/main/java/org/springframework/cloud/context/scope/thread/ThreadLocalScopeCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@

import java.util.ArrayList;
import java.util.Collection;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentMap;
import java.util.HashMap;
import java.util.Map;

import org.springframework.cloud.context.scope.ScopeCache;

Expand All @@ -29,9 +29,9 @@
*/
public class ThreadLocalScopeCache implements ScopeCache {

private ThreadLocal<ConcurrentMap<String, Object>> data = new ThreadLocal<ConcurrentMap<String, Object>>() {
protected ConcurrentMap<String, Object> initialValue() {
return new ConcurrentHashMap<String, Object>();
private ThreadLocal<Map<String, Object>> data = new ThreadLocal<Map<String, Object>>() {
protected Map<String, Object> initialValue() {
return new HashMap<String, Object>();
}
};

Expand All @@ -40,7 +40,7 @@ public Object remove(String name) {
}

public Collection<Object> clear() {
ConcurrentMap<String, Object> map = this.data.get();
Map<String, Object> map = this.data.get();
Collection<Object> values = new ArrayList<Object>(map.values());
map.clear();
return values;
Expand Down