Skip to content

Ignore maven-wrapper.jar by default #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ignore maven-wrapper.jar by default #1649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
!.mvn/wrapper/maven-wrapper.jar
.mvn/wrapper/maven-wrapper.jar
.flattened-pom.xml
.gradle
*.sw?
Expand Down
3 changes: 1 addition & 2 deletions ...java/io/spring/initializr/generator/spring/scm/git/GitProjectGenerationConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,7 @@ GitAttributes gitAttributes(ObjectProvider<GitAttributesCustomizer> gitAttribute
public GitIgnoreCustomizer mavenGitIgnoreCustomizer() {
return (gitIgnore) -> {
gitIgnore.getGeneral()
.add("target/", "!.mvn/wrapper/maven-wrapper.jar", "!**/src/main/**/target/",
"!**/src/test/**/target/");
.add("target/", ".mvn/wrapper/maven-wrapper.jar", "!**/src/main/**/target/", "!**/src/test/**/target/");
gitIgnore.getNetBeans().add("build/", "!**/src/main/**/build/", "!**/src/test/**/build/");
};
}
Expand Down
5 changes: 2 additions & 3 deletions ...io/spring/initializr/generator/spring/scm/git/GitProjectGenerationConfigurationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ void gitIgnoreGradle() {
.contains(".gradle", "build/", "!gradle/wrapper/gradle-wrapper.jar", "out/", "!**/src/main/**/build/",
"!**/src/test/**/build/", "!**/src/main/**/out/", "!**/src/test/**/out/", "bin/",
"!**/src/main/**/bin/", "!**/src/test/**/bin/")
.doesNotContain("/target/", "!.mvn/wrapper/maven-wrapper.jar");
.doesNotContain("/target/", ".mvn/wrapper/maven-wrapper.jar");
}

@Test
Expand All @@ -81,8 +81,7 @@ void gitIgnoreMaven() {
description.setBuildSystem(new MavenBuildSystem());
description.setPlatformVersion(Version.parse("2.1.0.RELEASE"));
assertThat(generateGitIgnore(description))
.contains("target/", "!.mvn/wrapper/maven-wrapper.jar", "!**/src/main/**/target/",
"!**/src/test/**/target/")
.contains("target/", ".mvn/wrapper/maven-wrapper.jar", "!**/src/main/**/target/", "!**/src/test/**/target/")
.doesNotContain(".gradle", "!gradle/wrapper/gradle-wrapper.jar", "/out/");
}

Expand Down
2 changes: 1 addition & 1 deletion initializr-generator-spring/src/test/resources/project/maven/gitignore.gen
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/target/
!.mvn/wrapper/maven-wrapper.jar
.mvn/wrapper/maven-wrapper.jar

### STS ###
.apt_generated
Expand Down