Skip to content

migrate junit4 to junit5 in JdbcChatMemoryRepositoryHsqldbAutoConfigIT #3633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

migrate junit4 to junit5 in JdbcChatMemoryRepositoryHsqldbAutoConfigIT #3633

wants to merge 1 commit into from
+6 −6

Conversation

dev-jonghoonpark
Copy link
Contributor

@dev-jonghoonpark dev-jonghoonpark commented Jun 22, 2025 •
edited
Loading

This PR migrates the JdbcChatMemoryRepositoryHsqldbAutoConfigurationIT test class from JUnit4 to JUnit5.

yuluo-yx
yuluo-yx approved these changes Jun 22, 2025
View reviewed changes
Copy link
Contributor

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

BTW, does this require deleting or excluding related dependencies?

@dev-jonghoonpark
Copy link
Contributor Author

dev-jonghoonpark commented Jun 22, 2025 •
edited
Loading

This PR does not modify dependencies.
It simply updates the code to use JUnit 5 for parts where it was found being used.

For reference, JUnit 4 seems to be included in com.squareup.okhttp3:mockwebserver.
As far as I checked, it seems there are no other parts using JUnit 4 except here.

sunyuhan1998
sunyuhan1998 approved these changes Jun 22, 2025
View reviewed changes
Copy link
Contributor

@sunyuhan1998 sunyuhan1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunyuhan1998 sunyuhan1998 sunyuhan1998 approved these changes

@yuluo-yx yuluo-yx yuluo-yx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dev-jonghoonpark @sunyuhan1998 @yuluo-yx