Refactor ChatResponse processing with Optional API #4292
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace if-else null checks with Optional chain - Improve code readability and maintain functional style Signed-off-by: eeaters <[email protected]>
Signed-off-by: YuJie Wan <[email protected]>
Signed-off-by: YuJie Wan <[email protected]>
sobychacko
added a commit
to sobychacko/spring-ai
that referenced
this pull request
Sep 18, 2025
Replace nested null checks and redundant branching with streamlined Optional-based approach. Since getResult() == getResults().get(0), processing all results handles both single and multiple result cases. Fixes spring-projects#4292 Signed-off-by: Soby Chacko <[email protected]>
sobychacko
added a commit
to sobychacko/spring-ai
that referenced
this pull request
Sep 19, 2025
Replace nested null checks and redundant branching with streamlined Optional-based approach. Since getResult() == getResults().get(0), processing all results handles both single and multiple result cases. Adding tests to verify. Fixes spring-projects#4292 Signed-off-by: Soby Chacko <[email protected]>
ilayaperumalg
pushed a commit
that referenced
this pull request
Sep 22, 2025
Replace nested null checks and redundant branching with streamlined Optional-based approach. Since getResult() == getResults().get(0), processing all results handles both single and multiple result cases. Adding tests to verify. Fixes #4292 Co-Authored-By: eeaters <[email protected]> Signed-off-by: Soby Chacko <[email protected]>
|
@eeaters Thanks for your PR. Merged the changes from @sobychacko on top of your proposal. Made sure to add you as the co-author to the merged commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ChatResponse::getResult equals ChatResponse.getResults().get(0), the else code block is unreachable.
Optimized the code to improve readability.