optimize ZhiPu Embedding to support batch embedding. #4308
Conversation
- support batch embedding - Make test adjustments based on the official demo Signed-off-by: YuJie Wan <[email protected]>
|
@mxsl-gr Could you help with the review of this PR? Thanks |
No problem, I’ve been busy with other tasks. I’ll review it later today. |
|
|
||
| EmbeddingRequest embeddingRequest = buildEmbeddingRequest(request); | ||
| var zhipuEmbeddingRequest = zhipuEmbeddingRequest(embeddingRequest); |
There was a problem hiding this comment.
this seems unnecessary. It might be cleaner to handle it in buildEmbeddingRequest instead of wrapping it with another request.
There was a problem hiding this comment.
this seems unnecessary. It might be cleaner to handle it in
buildEmbeddingRequestinstead of wrapping it with another request.
Influenced by the EmbeddingModelObservationContext, its context requirement mandates the use of org.springframework.ai.embedding.EmbeddingRequest;
However, the ZhiPu API uses ZhiPuAiApi.EmbeddingRequest, so they cannot be directly integrated into a single method.
so, I try to adjusting the order of the code to improve its readability.
There was a problem hiding this comment.
you‘re right, I really forgot about that. I think that works too.
Signed-off-by: YuJie Wan <[email protected]>
Fixes: #4232