Skip to content

Conversation

sunyuhan1998
Copy link
Contributor

The initializeContainer method of CosmosDBVectorStore has some issues:

  1. Most of the parameters in the method signature are not used, and these parameters don't need to be passed as arguments since they have already been assigned to instance properties in the constructor and can be directly accessed.
  2. The reassignment of parameters within the method is meaningless.

This PR makes the following changes:

  1. Removed all parameters from the method signature, as they are already accessible via instance properties.
  2. Eliminated meaningless reassignments of method parameters.

…torStore`: 1. Removed all parameters from the method signature, as they are already accessible via instance properties. 2. Eliminated meaningless reassignments of method parameters.

Signed-off-by: Sun Yuhan <[email protected]>
@ilayaperumalg
Copy link
Member

@sunyuhan1998 Thanks for the PR cleaning up the code. LGTM, merging.

@ilayaperumalg
Copy link
Member

Rebased and merged as 84efb6a. Also, cherry-picked into 1.0.x as f4a2aa9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants