Optimize MistralAiEmbeddingModel dimensions method #4810
+15
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nicolaskrier
commented
Nov 5, 2025
nicolaskrier
commented
- Calculate default value only if necessary
- Fix warnings in MistralAiEmbeddingModelTests unit tests
- Calculate default value only if necessary - Fix warnings in MistralAiEmbeddingModelTests unit tests Signed-off-by: Nicolas Krier <[email protected]>
|
Hi @ilayaperumalg, could you have a look on this one? I have been inspired by this commit for this PR. I have considered adding the cache feature as well but I was a bit concerned about making a class constant mutable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.