Skip to content

Pass when lower case's evaluation response contains 'yes' for FactCheckingEvaluator and RelevancyEvaluator. #4904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −7
Open

Pass when lower case's evaluation response contains 'yes' for FactCheckingEvaluator and RelevancyEvaluator. #4904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ient-chat/src/main/java/org/springframework/ai/chat/evaluation/FactCheckingEvaluator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ public EvaluationResponse evaluate(EvaluationRequest evaluationRequest) {
.call()
.content();

boolean passing = "yes".equalsIgnoreCase(evaluationResponse);
boolean passing = evaluationResponse != null && evaluationResponse.toLowerCase().contains("yes");
return new EvaluationResponse(passing, "", Collections.emptyMap());
}

Expand Down
8 changes: 2 additions & 6 deletions ...-client-chat/src/main/java/org/springframework/ai/chat/evaluation/RelevancyEvaluator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,8 @@ public EvaluationResponse evaluate(EvaluationRequest evaluationRequest) {

String evaluationResponse = this.chatClientBuilder.build().prompt().user(userMessage).call().content();

boolean passing = false;
float score = 0;
if ("yes".equalsIgnoreCase(evaluationResponse)) {
passing = true;
score = 1;
}
boolean passing = evaluationResponse != null && evaluationResponse.toLowerCase().contains("yes");
float score = passing ? 1 : 0;

return new EvaluationResponse(passing, score, "", Collections.emptyMap());
}
Expand Down