Add a property to fail fast for unresolvable placeholders in @ConfigurationProperties #45341
+46
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nosan
changed the title
spring-projects-issues
added
the
status: waiting-for-triage
nosan
changed the title
nosan
force-pushed
the
18816
branch
2 times, most recently
from
a0a6a42 to
9308764
Compare
…rationProperties Introduce the `spring.configurationproperties.ignore-unresolvable-placeholders` property to control whether an exception should be thrown when a property placeholder `${...}` cannot be resolved. Signed-off-by: Dmytro Nosan <[email protected]>
|
Thanks for the PR but I don't think we should focus on this property alone. We might want to customize the property replacement altogether and do it consistently (i.e. for the whole app). I am going to continue brainstorming on the original issue and your insights are very much appreciated. |
snicoll
added
status: declined
|
Thanks, @snicoll Indeed, this PR was focused solely on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the
spring.configurationproperties.ignore-unresolvable-placeholdersproperty to control whether an exception should be thrown when a property placeholder${...}cannot be resolved.See #18816