Skip to content

Polish #46505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Polish #46505

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,10 @@ void bindToCollectionWhenNonSequentialShouldThrowException() {
.satisfies((ex) -> {
Set<ConfigurationProperty> unbound = ((UnboundConfigurationPropertiesException) ex.getCause())
.getUnboundProperties();
assertThat(unbound).hasSize(1);
ConfigurationProperty property = unbound.iterator().next();
assertThat(property.getName()).hasToString("foo[3]");
assertThat(property.getValue()).isEqualTo("3");
assertThat(unbound).singleElement().satisfies((property) -> {
assertThat(property.getName()).hasToString("foo[3]");
assertThat(property.getValue()).isEqualTo("3");
});
});
}

Expand All @@ -139,10 +139,10 @@ void bindToCollectionWhenNonKnownIndexedChildNotBoundThrowsException() {
.satisfies((ex) -> {
Set<ConfigurationProperty> unbound = ((UnboundConfigurationPropertiesException) ex.getCause())
.getUnboundProperties();
assertThat(unbound).hasSize(1);
ConfigurationProperty property = unbound.iterator().next();
assertThat(property.getName()).hasToString("foo[1].missing");
assertThat(property.getValue()).isEqualTo("bad");
assertThat(unbound).singleElement().satisfies((property) -> {
assertThat(property.getName()).hasToString("foo[1].missing");
assertThat(property.getValue()).isEqualTo("bad");
});
});
}

Expand All @@ -155,10 +155,10 @@ void bindToNestedCollectionWhenNonKnownIndexed() {
source.put("foo[0].string", "test");
this.sources.add(source);
List<ExampleCollectionBean> list = this.binder.bind("foo", Bindable.listOf(ExampleCollectionBean.class)).get();
assertThat(list).hasSize(1);
ExampleCollectionBean bean = list.get(0);
assertThat(bean.getItems()).containsExactly("a", "b", "d");
assertThat(bean.getString()).isEqualTo("test");
assertThat(list).singleElement().satisfies((bean) -> {
assertThat(bean.getItems()).containsExactly("a", "b", "d");
assertThat(bean.getString()).isEqualTo("test");
});
}

@Test
Expand All @@ -173,10 +173,10 @@ void bindToNonScalarCollectionWhenNonSequentialShouldThrowException() {
.satisfies((ex) -> {
Set<ConfigurationProperty> unbound = ((UnboundConfigurationPropertiesException) ex.getCause())
.getUnboundProperties();
assertThat(unbound).hasSize(1);
ConfigurationProperty property = unbound.iterator().next();
assertThat(property.getName()).hasToString("foo[4].value");
assertThat(property.getValue()).isEqualTo("4");
assertThat(unbound).singleElement().satisfies((property) -> {
assertThat(property.getName()).hasToString("foo[4].value");
assertThat(property.getValue()).isEqualTo("4");
});
});
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
* properties.
* <p>
* Can be injected into application code and used to define a custom
* {@code RabbitTemplateConfigurer} whose configuration is based upon that produced by
* {@code RabbitTemplate} whose configuration is based upon that produced by
* auto-configuration.
*
* @author Stephane Nicoll
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
public class HttpMessageConvertersProperties {

/**
* The charset to use for String conversion.
* Charset to use for String conversion.
*/
private Charset stringEncodingCharset = StandardCharsets.UTF_8;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ default int compareTo(ObservationHandlerGroup other) {
Class<?> handlerType();

/**
* Static factory method to create a {@link ObservationHandlerGroup} with members of
* Static factory method to create an {@link ObservationHandlerGroup} with members of
* the given handler type.
* @param <H> the handler type
* @param handlerType the handler type
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
import org.springframework.util.MultiValueMap;

/**
* A collection {@link ObservationHandlerGroup} instance and supporting registration
* A collection of {@link ObservationHandlerGroup} instances and supporting registration
* logic.
*
* @author Andy Wilkinson
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
/**
* {@link ObservationHandlerGroup} that considers both {@link TracingObservationHandler}
* and {@link MeterObservationHandler} types as members. This group takes precedence over
* any regular {@link MeterObservationHandler} group in order to use ensure
* any regular {@link MeterObservationHandler} group in order to ensure
* {@link TracingAwareMeterObservationHandler} wrapping is applied during registration.
*
* @author Phillip Webb
Expand Down