Handle Docker 407 (Proxy Authentication Required) with clear error message #47180

siva-sai-udaygiri · 2025-09-12T18:14:48Z

Problem
When Docker returns 407 (Proxy Authentication Required), the response is often plain text, so the current code fails to surface a helpful error.

Solution

Special-case 407 in HttpClientTransport: if status == 407, read content and throw ProxyAuthenticationException with host/URI and details.
Parse JSON error if available; otherwise fall back to plain text.

Tests

Added ProxyAuthenticationExceptionTests to verify message/cause constructors.
(Happy to add/adjust HttpClientTransport tests per reviewer guidance.)

Notes

Only improves diagnostics; no success-path behavior changes.

Fixes: #46262

wilkinsona · 2025-09-18T11:02:44Z

...n/java/org/springframework/boot/buildpack/platform/docker/transport/HttpClientTransport.java

+
+					String detail = null;
+					Message json = deserializeMessage(content);
+					if (json != null && org.springframework.util.StringUtils.hasText(json.getMessage())) {


StringUtils is already imported so there's no need to fully-qualify the type.

wilkinsona · 2025-09-18T11:02:58Z

...n/java/org/springframework/boot/buildpack/platform/docker/transport/HttpClientTransport.java

+
+					String msg = "Proxy authentication required for host: " + this.host.toHostString() + ", uri: "
+							+ request.getUri()
+							+ (org.springframework.util.StringUtils.hasText(detail) ? " - " + detail : "");


StringUtils is already imported so there's no need to fully-qualify the type.

wilkinsona · 2025-09-18T11:03:38Z

...ingframework/boot/buildpack/platform/docker/transport/ProxyAuthenticationExceptionTests.java

+
+import static org.assertj.core.api.Assertions.assertThat;
+
+class ProxyAuthenticationExceptionTests {


I don't think we need tests for ProxyAuthenticationException. Please remove this class.

wilkinsona · 2025-09-18T11:42:34Z

...n/java/org/springframework/boot/buildpack/platform/docker/transport/HttpClientTransport.java

+						detail = json.getMessage();
+					}
+					else {
+						detail = new String(content, java.nio.charset.StandardCharsets.UTF_8);


StandardCharsets should be imported rather than using the fully-qualified type here.

wilkinsona · 2025-09-18T11:45:09Z

Also, please sign your commits as described in the DCO check failure.

wilkinsona · 2025-09-18T11:46:32Z

...n/java/org/springframework/boot/buildpack/platform/docker/transport/HttpClientTransport.java

-				response.close();
+
+				if (statusCode == 407) {
+					response.close();


This looks wrong to me as the response will now only be closed when the status code is 407.

…ssage (Fixes spring-projects#46262) Signed-off-by: Siva Sai Udayagiri <[email protected]>

siva-sai-udaygiri · 2025-09-19T20:47:37Z

Update:

Close response on all error paths before throwing.

Use imports (no fully-qualified names).

Removed ProxyAuthenticationExceptionTests.

Rebased, squashed, DCO signed.

wilkinsona · 2025-09-22T06:49:58Z

Those changes sound good, but I can't see them in the PR. Please check that you've pushed them.

…e FQNs Signed-off-by: Siva Sai Udayagiri <[email protected]>

siva-sai-udaygiri · 2025-09-22T17:54:30Z

Those changes sound good, but I can't see them in the PR. Please check that you've pushed them.

Pushed the updates: always close error responses, replaced FQNs with imports, removed ProxyAuthenticationExceptionTests.

wilkinsona · 2025-09-29T09:20:20Z

...n/java/org/springframework/boot/buildpack/platform/docker/transport/HttpClientTransport.java

-	/**
-	 * Perform an HTTP GET operation.
-	 * @param uri the destination URI
-	 * @return the operation response
-	 */


This javadoc should not be removed.

wilkinsona · 2025-09-29T09:20:27Z

...n/java/org/springframework/boot/buildpack/platform/docker/transport/HttpClientTransport.java

-	/**
-	 * Perform an HTTP POST operation.
-	 * @param uri the destination URI
-	 * @return the operation response
-	 */


This javadoc should not be removed.

wilkinsona · 2025-09-29T09:20:34Z

...n/java/org/springframework/boot/buildpack/platform/docker/transport/HttpClientTransport.java

-	/**
-	 * Perform an HTTP POST operation.
-	 * @param uri the destination URI
-	 * @param registryAuth registry authentication credentials
-	 * @return the operation response
-	 */


This javadoc should not be removed.

wilkinsona · 2025-09-29T09:20:40Z

...n/java/org/springframework/boot/buildpack/platform/docker/transport/HttpClientTransport.java

-	/**
-	 * Perform an HTTP POST operation.
-	 * @param uri the destination URI
-	 * @param contentType the content type to write
-	 * @param writer a content writer
-	 * @return the operation response
-	 */


This javadoc should not be removed.

wilkinsona · 2025-09-29T09:20:45Z

...n/java/org/springframework/boot/buildpack/platform/docker/transport/HttpClientTransport.java

-	/**
-	 * Perform an HTTP PUT operation.
-	 * @param uri the destination URI
-	 * @param contentType the content type to write
-	 * @param writer a content writer
-	 * @return the operation response
-	 */


This javadoc should not be removed.

wilkinsona · 2025-09-29T09:20:51Z

...n/java/org/springframework/boot/buildpack/platform/docker/transport/HttpClientTransport.java

-	/**
-	 * Perform an HTTP DELETE operation.
-	 * @param uri the destination URI
-	 * @return the operation response
-	 */


This javadoc should not be removed.

wilkinsona · 2025-09-29T09:21:26Z

...n/java/org/springframework/boot/buildpack/platform/docker/transport/HttpClientTransport.java

+
 			if (statusCode >= 400 && statusCode <= 500) {
 				byte[] content = readContent(response);
+				// Always close the response for error paths


This comment is not necessary. Please remove.

wilkinsona · 2025-09-29T09:27:17Z

...n/java/org/springframework/boot/buildpack/platform/docker/transport/HttpClientTransport.java

+							+ request.getUri()
+							+ (StringUtils.hasText(detail) ? " - " + detail : "");
+
+					throw new ProxyAuthenticationException(msg);


I'm still not sure that this is needed. Could it be a DockerEngineException with a better message?

Please address this comment.

wilkinsona · 2025-09-29T09:28:08Z

...n/java/org/springframework/boot/buildpack/platform/docker/transport/HttpClientTransport.java

+				// Always close the response for error paths
 				response.close();
+
+				if (statusCode == 407) {


Use SC_PROXY_AUTHENTICATION_REQUIRED from org.apache.hc.core5.http.HttpStatus here rather than 407.

wilkinsona · 2025-09-29T09:29:50Z

...n/java/org/springframework/boot/buildpack/platform/docker/transport/HttpClientTransport.java

+					Message json = deserializeMessage(content);
+					if (json != null && StringUtils.hasText(json.getMessage())) {
+						detail = json.getMessage();
+					}


Why are you handling JSON here? The issue states that the error has "a plain text message".

This still doesn't look right to me, I'm afraid. Why would a JSON Message be sent back in an error case? If you have evidence of that, please do share it. Otherwise, I think this should just deal with plain text.

Thanks for the nudge. I’ve removed the JSON handling—407 is now treated as plain-text only.

…ant; restore Javadoc; remove comment Signed-off-by: Siva Sai Udayagiri <[email protected]>

siva-sai-udaygiri · 2025-10-03T19:55:10Z

Pushed updates: restored Javadoc, removed inline comment, switched to HttpStatus.SC_PROXY_AUTHENTICATION_REQUIRED, and ensured response is always closed on error. Formatting & checkstyle pass. Thanks!

…sponse on error Signed-off-by: Siva Sai Udayagiri <[email protected]>

siva-sai-udaygiri · 2025-10-24T18:13:43Z

Update pushed:

Handle 407 as plain text only (no JSON parsing).

Close the ClassicHttpResponse on all 4xx/5xx paths before throwing.

Use HttpStatus.SC_PROXY_AUTHENTICATION_REQUIRED instead of the literal.

Restored the Javadocs that were removed and dropped the “Always close…” inline comment.

spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 12, 2025

wilkinsona requested changes Sep 18, 2025

View reviewed changes

wilkinsona reviewed Sep 18, 2025

View reviewed changes

Handle Docker 407 (Proxy Authentication Required) with clear error me…

1bd6ffe

…ssage (Fixes spring-projects#46262) Signed-off-by: Siva Sai Udayagiri <[email protected]>

siva-sai-udaygiri force-pushed the 3.3.x branch 2 times, most recently from 7348c31 to 1bd6ffe Compare September 19, 2025 20:42

Handle Docker 407: always close response on error; use imports; remov…

dea1f3c

…e FQNs Signed-off-by: Siva Sai Udayagiri <[email protected]>

wilkinsona requested changes Sep 29, 2025

View reviewed changes

Handle Docker 407: always close error responses; use HttpStatus const…

b31f951

…ant; restore Javadoc; remove comment Signed-off-by: Siva Sai Udayagiri <[email protected]>

Handle Docker 407: treat response as plain text only; always close re…

ecdb0d3

…sponse on error Signed-off-by: Siva Sai Udayagiri <[email protected]>


		import static org.assertj.core.api.Assertions.assertThat;

		class ProxyAuthenticationExceptionTests {

Uh oh!

Handle Docker 407 (Proxy Authentication Required) with clear error message #47180

Are you sure you want to change the base?

Handle Docker 407 (Proxy Authentication Required) with clear error message #47180

Uh oh!

Conversation

siva-sai-udaygiri commented Sep 12, 2025

Uh oh!

wilkinsona Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wilkinsona Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wilkinsona commented Sep 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

siva-sai-udaygiri commented Sep 19, 2025

Uh oh!

wilkinsona commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

siva-sai-udaygiri commented Sep 22, 2025 • edited by wilkinsona Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

siva-sai-udaygiri commented Oct 3, 2025

Uh oh!

siva-sai-udaygiri commented Oct 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wilkinsona Sep 18, 2025 •

edited

Loading

wilkinsona Sep 18, 2025 •

edited

Loading

wilkinsona commented Sep 22, 2025 •

edited

Loading

siva-sai-udaygiri commented Sep 22, 2025 •

edited by wilkinsona

Loading