-
Notifications
You must be signed in to change notification settings - Fork 696
Refine TypeCollector
usage and predicates
#3363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeCollector
TypeCollector
usage and predicates
mp911de
commented
Sep 18, 2025
* @author Mark Paluch | ||
* @since 4.0 | ||
*/ | ||
public interface TypeCollectorPredicateProvider { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we renamed this to TypeCollectorPredicates
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a bit confusing, naming it predicates, TypeCollectorFilterProvider
maybe?
We now provide a SPI for libraries that want to provide predicates for AOT processing so that AOT processing not only considers its own rules but also e.g. exclusions from other participants on the class path.
Rename TypeCollectorPredicateProvider -> TypeCollectorFilters Update javadoc and deprecate jpa specific predicate.
76cceef
to
14caf37
Compare
christophstrobl
added a commit
that referenced
this pull request
Sep 18, 2025
Rename TypeCollectorPredicateProvider -> TypeCollectorFilters Update javadoc and deprecate jpa specific predicate. Original Pull Request: #3363
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make predicates on
TypeCollector
usable, introduce strategy interface so that AOT participants can contribute their own predicates for inclusion/exclusion of types that should be considered reachable.