-
Notifications
You must be signed in to change notification settings - Fork 38.6k
Make targetBeanName
field in AbstractBeanFactoryBasedTargetSource protected
to avoid exceptions in logging and toString()
#35172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+9
−9
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
eb348c3
Add a palin method getPlainTargetBeanName
chenggwang bbd255b
Using getPlainTargetBeanName() instead of getTargetBeanName
chenggwang 58e20f2
Using getPlainTargetBeanName() instead of getTargetBeanName
chenggwang 2751c6a
Using getPlainTargetBeanName() instead of getTargetBeanName
chenggwang bb16861
Change the modifier of targetBeanName from private to protected
chenggwang d501894
directly access targetBeanName using this.targetBeanName
chenggwang 32eff63
directly access targetBeanName using this.targetBeanName
chenggwang 434e5b7
directly access targetBeanName using this.targetBeanName
chenggwang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that this does not compile with
this.
.In the future, please run a full local build before pushing changes to a PR.
For this particular case, I fixed the issue while merging this PR onto
6.2.x
, so this has been taken care of.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry I thought can be completed with simple text editor, I know the inner class general use
ThreadLocalTargetSource.this.targetBeanName
, The grammar plugin reminds me that perhaps what I want to use is:this.
I thought this was a new grammar,I followed the advice of the plugin!!! This is a stupid mistake😭. In the future,i will run a full local build! Sorry to have caused you trouble! @sbrannen