StopWatchTests: improve test cases #36028
Closed
+65
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uncomment flaky assertions and replace with deterministic implementation Signed-off-by: Vincent Stradiot <[email protected]>
Uncomment flaky assertions and replace with deterministic implementation Signed-off-by: Vincent Stradiot <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
Uncomment flaky assertions and replace with deterministic implementation Signed-off-by: Vincent Stradiot <[email protected]>
Uncomment flaky assertions and replace with deterministic implementation Signed-off-by: Vincent Stradiot <[email protected]>
Member
|
Test hasn't been flaky over the last 6 months. 
|
bclozel
added
status: declined
Author
|
@bclozel They aren't flaky because all the asserts are commented out on the main branch, which is not ideal (see image below). Up to you to decide. Let met know if you want me to reactivate/recreate this PR. 
|
Member
|
I don't think it's worth it in this current form. We could consider completely rewriting the class and its tests but it's definitely not our priority. Thanks for the suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, here is a Pull Request that improves the test cases for
StopWatchby:Thread.sleepin unit testsThank you for the review, and have a nice day.