Mark GrantedAuthority#getAuthority as @Nullable
#18014
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
Currently, the build crashes in the Note: Now it is fixed |
...a/org/springframework/security/web/access/DelegatingMissingAuthorityAccessDeniedHandler.java
Outdated
Show resolved
Hide resolved
therepanic
force-pushed
the
gh-17999
branch
3 times, most recently
from
54f53fc to
e16ab55
Compare
...a/org/springframework/security/web/access/DelegatingMissingAuthorityAccessDeniedHandler.java
Outdated
Show resolved
Hide resolved
Closes: spring-projectsgh-17999 Signed-off-by: Andrey Litvitski <[email protected]>
| * precision). | ||
| */ | ||
| String getAuthority(); | ||
| @Nullable String getAuthority(); |
There was a problem hiding this comment.
Question :: though this implementation supports null case, but it is supposed to be avoided (as per the documentation -> returning null should be avoided unless actually required. ) So dont we losing the feature/control with the overall changes?
@therepanic @rwinch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
GrantedAuthority#getAuthoritycontract itself implies that it can return null, we should mark it as@Nullable.Closes: gh-17999