Conversation
Preparation for per-document response validation. Test-only; no API changes. The tests modules at the end of some files were getting very large, which would make the PR reviews harder so I decided to move them in their own files. REF ACC-1912
SeaSkyThe
approved these changes
Aug 31, 2026
w4ll3
reviewed
Sep 21, 2026
| &pki.fetcher_revoking(&[pki.leaf_serial()]), | ||
| ) | ||
| .await; | ||
| assert!(!outcome.success(), "a revoked signer should not validate"); |
Member
There was a problem hiding this comment.
Assert that outcome.errors contains the text certificate is revoked, any failure could make this successful.
| /// moving the MSO's [`ValidityInfo`](crate::definitions::ValidityInfo) over | ||
| /// pinning validation time — pinning moves the certificate window too. | ||
| /// | ||
| /// `crl_url` is `None` unless the test exercises CRL fetching; see |
Member
There was a problem hiding this comment.
crl_url is defined as String bellow, how could it be None?
| /// - CRL Number (5.2.3, M) | ||
| pub(crate) fn build_crl_extensions(root_cert: &Certificate) -> Vec<Extension> { | ||
| use const_oid::AssociatedOid; | ||
| use der::{Decode, Encode}; |
Member
There was a problem hiding this comment.
Decode at top level already
Suggested change
| use der::{Decode, Encode}; | |
| use der::Encode; |
w4ll3
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparation for per-document response validation. Test-only; no API
changes.
The tests modules at the end of some files were getting very large,
which would make the PR reviews harder so I decided to move them in
their own files.
REF ACC-1912