Invalid name generation when using python reserved keywords #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88
To fix this issue, here is my proposition:
class
reserved keyword byclass_
.validate_by_name
to allow us to define the class usingAuthor(class_=...)
.validate_by_alias
to allow JSON serde.Changes overview
internal/poet/reserved.go
to append_
to reserved names.internal/gen.go::pydanticNode
to addmodel_config = pydantic.ConfigDict
internal/gen.go::fieldNode
:_
and addpydantic.Field(...)
_
Questions / possible issues
make test
is it correct ?sqlc v1.28.0
tosqlc v1.29.0
is this intended ?internal/poet/reserved.go
I hardcodedreservedKeywords
we should double check it and check if we want to keep it like that.