Skip to content

Improve better-sqlite3 type bindings #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve better-sqlite3 type bindings #45

wants to merge 1 commit into from
+11 −9

Conversation

zareith
Copy link

@zareith zareith commented Oct 20, 2024 •
edited
Loading

  • Ensure that varchar/text types are mapped to string type (and not any)
  • Remove usage of Date because better-sqlite3 can not actually bind non-primitive values
  • Remove usage of booleans because sqlite doesn't have boolean type and better-sqlite3 doesn't do any number to boolean conversion

@zareith zareith force-pushed the sqlite3-type-bindings branch from 58abf9d to 9caacbb Compare October 20, 2024 10:10
@zareith zareith force-pushed the sqlite3-type-bindings branch from 9caacbb to 1de49c2 Compare October 20, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@zareith