fix(sqlite): introduce "update from..." to the parser #3610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ooooh finally 🙏 |
|
Any update on this? 🙏 |
|
also waiting for this fix. |
|
Thank you for that !!! |
|
Hey @kyleconroy, I wanted to follow up on this PR, and see if there’s anything I can do to help move it toward merging. If there’s any feedback or additional work needed on my end, please let me know - I’d be happy to make adjustments to ensure it aligns with sqlc's vision. Thanks! |
kyleconroy
force-pushed
the
idokendo/fix-update-from-in-sqlite
branch
from
2c8b51e to
5b6ffd3
Compare
|
Hey @kyleconroy 👋 |
|
Hi again @kyleconroy , any chance you can find the time to review and help merge this PR? thanks! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #3132 by adding the
update from...syntax to the sqliteupdate_stmtparser.Was tested locally with several different queries.
Please let me know if there's anything more required to get this in or if you have any comments.