Skip to content

Fix types #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

Fix types #107

merged 1 commit into from
Apr 4, 2025

Conversation

drozycki
Copy link
Contributor

@drozycki drozycki commented Apr 4, 2025

Fix for #102

There is a mismatch between the symbols in the type declaration and what the API actually expects. This fixes some of the inconsistencies in API related to registering a VFS.

@drozycki drozycki mentioned this pull request Apr 4, 2025
Copy link
Collaborator

@tomayac tomayac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for the PR. You write that this fixes "some" of the issues raised in #102, should we keep #102 open after this present PR gets merged? You've looked more deeply into this, so I trust your judgement more than mine.

@drozycki
Copy link
Contributor Author

drozycki commented Apr 4, 2025

I think it can be closed as it fixes the symbols mentioned in the discussion and there is nothing actionable left to do.

@tomayac tomayac merged commit 1fbd900 into sqlite:main Apr 4, 2025
@tomayac
Copy link
Collaborator

tomayac commented Apr 4, 2025

Thank you! Released as 3.49.1-build4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants