-
-
Notifications
You must be signed in to change notification settings - Fork 160
Fix sqlpage run_sql data mismatch error #1105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sqlpage run_sql data mismatch error #1105
Conversation
Co-authored-by: contact <[email protected]>
|
Cursor Agent can help with this pull request. Just |
|
@cursoragent don't rewrite a custom parammap deserializer just for run_sql. Just improve the error messages both in the general parammap deserializer and attach precise descriptive human friendly context to the error in the run_sql call |
|
Makes sense—I'll drop the bespoke
That way we reuse the shared deserializer, and Learn more about Cursor Agents |
Co-authored-by: contact <[email protected]>
|
@cursoragent no new dependency allowed |
|
Got it—I'll drop Learn more about Cursor Agents |
Co-authored-by: contact <[email protected]>
Co-authored-by: contact <[email protected]>
Add
parse_run_sql_variablesto validatesqlpage.run_sqlarguments and provide more descriptive error messages.The previous error message "data did not match any variant of untagged enum SingleOrVec" was unhelpful when
sqlpage.run_sqlreceived invalid variable types. This change introduces specific error messages that identify the problematic variable and expected format.