Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap non-default nio filesystems with new Okio APIs #2548

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Wrap non-default nio filesystems with new Okio APIs #2548

merged 1 commit into from
Sep 5, 2023

Conversation

oldergod
Copy link
Member

No description provided.

@oldergod oldergod requested a review from swankjesse July 22, 2023 06:29
oldergod
oldergod commented Jul 22, 2023
View reviewed changes
wire-compiler/src/main/java/com/squareup/wire/schema/fileSystems.kt Outdated
Comment on lines 24 to 25
this == FileSystems.getDefault() -> okio.FileSystem.SYSTEM
else -> error("Wire doesn't support non-default file system: $this")
else -> this.asOkioFileSystem()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe just replace wire's toOkioFileSystem() and use okio's asOkioFileSystem() all the time?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@oldergod oldergod merged commit a3d2c2c into master Sep 5, 2023
14 checks passed
@oldergod oldergod deleted the bquenaudon.2023-07-22.fs branch September 5, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Egorand Egorand Egorand approved these changes

@swankjesse swankjesse Awaiting requested review from swankjesse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oldergod @Egorand