Skip to content

[DNM] Enable Stability Flags on Screen and ComposeScreen #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+29 −4
Draft

[DNM] Enable Stability Flags on Screen and ComposeScreen #1264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a48211
[DNM] Enable Stability Flags on Screen and ComposeScreen
mhiew Feb 12, 2025
905579c
Apply changes from dependencyGuardBaseline --refresh-dependencies
mhiew Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions workflow-ui/compose/src/main/java/com/squareup/workflow1/ui/compose/ComposeScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package com.squareup.workflow1.ui.compose

import androidx.compose.runtime.Composable
import androidx.compose.runtime.Stable
import com.squareup.workflow1.ui.Screen
import com.squareup.workflow1.ui.ViewEnvironment
import com.squareup.workflow1.ui.ViewRegistry
Expand Down Expand Up @@ -73,6 +74,7 @@ import com.squareup.workflow1.ui.WorkflowUiExperimentalApi
* will be wrapped with the [CompositionRoot]. See the documentation on [CompositionRoot] for
* more information.
*/
@Stable
@WorkflowUiExperimentalApi
public interface ComposeScreen : Screen {

Expand Down
8 changes: 6 additions & 2 deletions workflow-ui/core-android/dependencies/releaseRuntimeClasspath.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
androidx.activity:activity:1.8.2
androidx.annotation:annotation-experimental:1.4.0
androidx.annotation:annotation-experimental:1.4.1
androidx.annotation:annotation-jvm:1.8.1
androidx.annotation:annotation:1.8.1
androidx.arch.core:core-common:2.2.0
androidx.arch.core:core-runtime:2.2.0
androidx.collection:collection:1.1.0
androidx.collection:collection-jvm:1.4.4
androidx.collection:collection:1.4.4
androidx.compose.runtime:runtime-android:1.7.2
androidx.compose.runtime:runtime:1.7.2
androidx.compose:compose-bom:2024.09.02
androidx.concurrent:concurrent-futures:1.1.0
androidx.core:core-ktx:1.13.1
androidx.core:core:1.13.1
Expand Down
4 changes: 4 additions & 0 deletions workflow-ui/core-common/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,13 @@ plugins {
}

dependencies {
val composeBom = platform(libs.androidx.compose.bom)
implementation(composeBom)

api(libs.kotlin.jdk6)
api(libs.kotlinx.coroutines.core)
api(libs.squareup.okio)
api(libs.androidx.compose.runtime)

testImplementation(libs.junit)
testImplementation(libs.kotlin.test.core)
Expand Down
7 changes: 7 additions & 0 deletions workflow-ui/core-common/dependencies/runtimeClasspath.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
androidx.annotation:annotation-jvm:1.8.1
androidx.annotation:annotation:1.8.1
androidx.collection:collection-jvm:1.4.4
androidx.collection:collection:1.4.4
androidx.compose.runtime:runtime-jvmstubs:1.7.2
androidx.compose.runtime:runtime:1.7.2
androidx.compose:compose-bom:2024.09.02
com.squareup.okio:okio-jvm:3.3.0
com.squareup.okio:okio:3.3.0
org.jetbrains.kotlin:kotlin-bom:1.9.24
Expand Down
4 changes: 4 additions & 0 deletions workflow-ui/core-common/src/main/java/com/squareup/workflow1/ui/Screen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
package com.squareup.workflow1.ui

import androidx.compose.runtime.Stable

/**
* Marker interface implemented by renderings that map to a UI system's 2d view class.
*/

@Stable
@WorkflowUiExperimentalApi
public interface Screen
8 changes: 6 additions & 2 deletions workflow-ui/radiography/dependencies/releaseRuntimeClasspath.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
androidx.activity:activity:1.8.2
androidx.annotation:annotation-experimental:1.4.0
androidx.annotation:annotation-experimental:1.4.1
androidx.annotation:annotation-jvm:1.8.1
androidx.annotation:annotation:1.8.1
androidx.arch.core:core-common:2.2.0
androidx.arch.core:core-runtime:2.2.0
androidx.collection:collection:1.1.0
androidx.collection:collection-jvm:1.4.4
androidx.collection:collection:1.4.4
androidx.compose.runtime:runtime-android:1.7.2
androidx.compose.runtime:runtime:1.7.2
androidx.compose:compose-bom:2024.09.02
androidx.concurrent:concurrent-futures:1.1.0
androidx.core:core-ktx:1.13.1
androidx.core:core:1.13.1
Expand Down
Loading