Skip to content

Refactor WorkflowNode into AbstractWorkflowNode <- StatefulWorkflowNode. #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zach-klippenstein
Copy link
Collaborator

@zach-klippenstein zach-klippenstein commented Jun 24, 2025

This is to prepare for go/compose-based-workflows.

This is two commits to make git diff recognize the extracted abstract class as the new file instead of the WorkflowNode -> StatefulWorkflowNode rename. However, github doesn't get this and shows StatefulWorkflowNode as a net new file, so it's must easier to review if you only look at the first commit.

@zach-klippenstein zach-klippenstein force-pushed the zachklipp/workflownode-poly branch 2 times, most recently from ddf7e1c to 88c9beb Compare July 15, 2025 22:39
This is to prepare for go/compose-based-workflows.
This intermediate rename was to help git show the correct history for StatefulWorkflowNode.
@zach-klippenstein zach-klippenstein force-pushed the zachklipp/workflownode-poly branch from b4e82d7 to 05cad44 Compare July 15, 2025 22:46
@zach-klippenstein
Copy link
Collaborator Author

  • Check that merging these 2 commits will still cause git to show file history for WorkflowNode -> StatefulWorkflowNode. If not, then split into 2 separate PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant