Move workflow-runtime-android into android source set in workflow-runtime module. #1370
+200
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zach-klippenstein
added a commit
that referenced
this pull request
Jul 16, 2025
Validates behavior with `Dispatchers.Main` and `.immediate`. This can't be merged as-is, since it requires the tests to live in the android source set but that's in a different module so it can't see WSD. Need to land #1370 first.
zach-klippenstein
force-pushed
the
zachklipp/runtime-android
branch
from
f4deb36 to
792336a
Compare
zach-klippenstein
changed the title
zach-klippenstein
changed the base branch from
main
to
zachklipp/remove-valueclass
zach-klippenstein
force-pushed
the
zachklipp/runtime-android
branch
from
42c5a9c to
3c493f3
Compare
zach-klippenstein
force-pushed
the
zachklipp/runtime-android
branch
from
d78e1b4 to
4f94404
Compare
rjrjr
approved these changes
Jul 17, 2025
steve-the-edwards
approved these changes
Jul 18, 2025
…time module. This keeps all the runtime code in the same module, reducing the number of dependencies external code need to specify, and making it possible for our android-specific runtime code to directly access internal code in the runtime module, and satisfy more specific expect/actuals. It also lets us write android-specific tests for runtime code. Additionally, this helps pave the way for go/compose-based-workflows.
zach-klippenstein
force-pushed
the
zachklipp/runtime-android
branch
from
4f94404 to
79354e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps all the runtime code in the same module, reducing the number of dependencies
external code need to specify, and making it possible for our android-specific runtime
code to directly access internal code in the runtime module, and satisfy more specific
expect/actuals. It also lets us write android-specific tests for runtime code.
Additionally, this helps pave the way for go/compose-based-workflows.
I've tested this by publishing to maven local and consuming from Register.