Move SnapshotParcels.kt to workflow-core. #1373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zach-klippenstein
force-pushed
the
zachklipp/snapshotparcels
branch
from
93e8a16 to
63124d3
Compare
rjrjr
approved these changes
Jul 17, 2025
zach-klippenstein
force-pushed
the
zachklipp/runtime-android
branch
from
4f94404 to
79354e3
Compare
This gives workflow-core an android source set and moves the Parcelable-related Snapshot helpers to it. This makes more sense since the other Snapshot helpers are in the core module, and Parcelable isn't a UI thing it's just an android thing. This also paves the way for go/compose-based-workflow to use these helpers to support `rememberSaveable`.
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
zach-klippenstein
force-pushed
the
zachklipp/snapshotparcels
branch
from
7e47bf9 to
d0ac746
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives workflow-core an android source set and moves the Parcelable-related Snapshot helpers to it. This makes more sense since the other Snapshot helpers are in the core module, and Parcelable isn't a UI thing it's just an android thing.
This also paves the way for go/compose-based-workflow to use these helpers to support
rememberSaveable.