Stream emulator data into workflow visualizer app #1374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Streamed data takes in a list of nodes at a time, but a trace file has lists of lists of nodes, so we use generics to differentiate them
Supplying generics don't seem to work and runs into error with nesting. This solution supplies a type for moshi and forces a cast to the desired type.
Extend TraceMode logic by using it to store the file/socket being used in the specific mode. The logic of rendering will depend on the type of TraceMode
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Previously, the use of types and manually casting was due to type erasure. But using kotlin's typeOf allows us to still supply the nested types.
This will always show the most recent workflow
Since reader.readLine() is a blocking call, it's difficult to pause/end when socket.close() is called. Instead we just try-catch for when the error occurs after closing.
wenli-cai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using Unix Domain Sockets and adb forwarding, the visualizer is able to retrieve logged data directly from the emulator to display the workflow render passes.
The app has also been changed to allow for both File and Live tracing mode through a toggle.