Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP UI Observation with typed events #209

Closed
wants to merge 1 commit into from

Conversation

amorde
Copy link
Member

@amorde amorde commented May 11, 2023

Compare with #208 and #210

Pros

  • More concise observer protocol definition
  • Easily portable to other observation systems (ex. FRP frameworks) by passing the types through
  • Can easily be extended / customized to support listening to only a single event type
  • Adding fields to an existing event is backwards compatible
  • Adding new events is backwards compatible

Cons

  • No way to pattern match over a concrete list of possible events
  • Adding a new case to the enum is backwards incompatible
  • Does not match existing observation APIs for Workflow

@amorde amorde changed the title WIP WIP UI Observation with typed events May 11, 2023
@amorde amorde closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant