-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve Bazel dylib issue due to aggressive code stripping #321
Conversation
@@ -44,6 +44,7 @@ open class ScreenViewController<ScreenType: Screen>: WorkflowUIViewController { | |||
ScreenType.self | |||
} | |||
|
|||
@_alwaysEmitIntoClient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be great to add some context around this so that future-us will know what the heck this was added for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also... is this a workaround for a linker issue? can we deal with it via build args/configuration vs changing the source? is this a bug that should be reported somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a workaround for a linker issue?
This is a linker issue; however, it works fine in SPM land. There's something about the Square Bazel build infrastructure (and the current versions we're pinned at) which results in this.
can we deal with it via build args/configuration vs changing the source?
@congt tried a ton of things, and this was the only thing we could do to solve it previously
is this a bug that should be reported somewhere?
Hard to say since it's Bazel specific and possibly Square's rules specific
Some context: Slack
|
The dylib being generated internally is code stripping private vars incorrectly. This should resolve it.
Checklist
N/A / validated by internal CI