Fixed favicon path

[squidfunk]

This PR ensures that the favicon path is absolute if site_url is set, and attempt to fix #8066.

[kamilkrzyskow]

This was the initial idea, taken from Google docs and W3Schools, however as mentioned later this site:

• https://matteobaccan.github.io/owner/
  <link rel="icon" type="image/x-icon" href="https://matteobaccan.github.io/owner/favicon.png" />

Has been using the site_url and favicon combo for 12 years.

Therefore it's unlikely that it would help with the detection in general 😞

It looks like currently the root domain favicon or lack of it will be prioritized over everything 😞

So the current solution is to add the favicon on the root domain or add a redirection, which works on GMC, or does it...?

GMC could also be using a cached icon from the time it did work and the redirection doesn't help on Google, just appears to help for now.

Apart of that the change LGTM. The docs could mention that using an user/organization level GitHub Pages https://pages.github.com/ additionally to the repository project page could help the most.

[squidfunk]

Thanks! Let's wait for 2 weeks and then check our search results. If it did not help, we can close this PR.

[niclasheinz]

Maybe I'm too stupid to understand the real problem here, but there is a “default” favicon set in the docs that no longer exists in the repository. In the docs there is a link to the default image , which no longer exists. In my opinion, the correct favicon is here. Plus, I can't see any favicon in the docs/assets folder.
Maybe this is just a problem with the documentation

[kamilkrzyskow]

The documentation issue is separate, but you're right that the old link wasn't updated after the switch to using the templates directory.

In 56b96b4 the theme data was moved, but for the end-user the way it's accessed stayed the same, as the templates directory became the root for the theme.

Plus, I can't see any favicon in the docs/assets folder.

You won't find it there because it's exposed as part of the theme, which you linked above

the correct favicon is here.

The theme root works like customization:

• https://squidfunk.github.io/mkdocs-material/customization/#extending-the-theme

The files inside are merged with the final site build, the favicon is provided for all users by default.
You can see the favicon here, because the creators only configured the logo:

• https://hewlettpackard.github.io/squest/