Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sidebar on Firefox mobile #8085

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Fixed sidebar on Firefox mobile #8085

merged 1 commit into from
Mar 13, 2025

Conversation

squidfunk
Copy link
Owner

Attempt to fix #8067.

@kamilkrzyskow
Copy link
Collaborator

kamilkrzyskow commented Mar 13, 2025

I'd say LGTM, because the change does remove the gutter on mobile, I compared it with the previous commit 74a7835 which still had the bug. However, it sort of breaks when zoomed in on my PC, because there is a state where the CSS doesn't detect tablet mode, and where it has the drawer. I doubt you're targetting such case, but perhaps you could combine this tablet limiter with the ul change I mentioned in the issue where effect is a bit more subtle, I pushed the branch so you can compare if it's worthwhile to include ✌️

Works on mobile

image

Doesn't work with a specific zoom level on PC

image

@squidfunk
Copy link
Owner Author

Thanks for validating!

Media queries and zooming are an open problem, and it is a problem that is orthogonal to the matters discussed here. The media queries should actually handle text zoom, but browser zoom might be something different. Thus, I'd not consider this right now, but we'll look into it when we do the next complete makeover.

@squidfunk squidfunk merged commit 3296cdf into master Mar 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firefox rendering issue - side menu gap
2 participants