fix(logic): natives (#29), fakeclients (#30) - #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two bugs affecting the ThirdPerson plugin's reliability:
Fix: Swapped native return values (#29)
Native_Mirrorwas returningg_bThirdPerson[client]andNative_ThirdPersonwas returning
g_bMirror[client]— both were inverted. This caused any pluginrelying on these natives to receive incorrect state values.
Fix: Fakeclient guard on SendConVarValue (#30)
SendConVarValuewas being called unconditionally inMirrorOnandMirrorOff,including for bots (fake clients) which do not have a network connection.
This could lead to runtime errors or unexpected behavior on servers with bots.
Both calls are now wrapped in an
!IsFakeClient(client)check.Fix: Missing reset of g_bMirror in OnClientPutInServer
g_bMirror[client]was not being reset tofalseon client connect, unlikeg_bThirdPerson. This could leave stale state from a previous occupant ofthe same client slot.
Version bump: 1.3.4 → 1.3.5