per_page to perPage to fix pagination#25
Open
Blastbrean wants to merge 1 commit intosreedevk:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cool library and thanks for making sure it doesn't break. It's very useful while creating my own software with it.
A minor issue I found was that the parameter "per_page" is an invalid parameter and will be ignored which is unintended. Instead of giving our expected items per page, we'll get the default items per page which is 30.
In order to fix this, simply make the request align with the PocketBase API list documentation and show the correct parameter name "perPage" instead.