This repository was archived by the owner on Jan 25, 2024. It is now read-only.
Add Pull Request Guidelines to documentation. #539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trickeydan
requested review from
kierdavis,
RealOrangeOne,
sedders123 and
tpoomlmly
|
Code Climate has analyzed commit b820033 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (95% is the threshold). This pull request will bring the total coverage in the repository to 90.0% (0.0% change). View more on Code Climate. |
sedders123
reviewed
Feb 11, 2020
There was a problem hiding this comment.
Thanks for kicking off this discussion @trickeydan! I agree with pretty much everything here just have a few extra ideas that could use some thought
sedders123
approved these changes
May 29, 2020
There was a problem hiding this comment.
Thanks @trickeydan this looks great! Just have a minor suggestion about the wording around semver labels but I don't consider that a blocker if you disagree.
Co-authored-by: James Seden Smith <[email protected]>
Co-authored-by: James Seden Smith <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #397
I'd like to see multiple people look through this. It is based on how we've usually done it in SR/SB/j5/SRO. There are definitely some parts that could be considered opinionated and I welcome discussion on these.