Conversation
📝 WalkthroughWalkthroughДобавлены три новых корабля-шаттла (Falcon, Phantom, Mojave) с полными конфигурационными файлами карт, сущностями ваучеров и интеграцией в систему верфи. Все изменения — это определение данных без изменения логики кода. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can generate a title for your PR based on the changes.Add |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Resources/Maps/_Crescent/Shuttles/NAP/falcon.yml`:
- Around line 398-403: The Falcon map entry still contains copy-paste values
from Sabre; update the VesselIcon/iffIcon state from "fighter" to "ultralight"
to match the Falcon prototype and change the BecomesStation id from "Sabre" to
"Falcon" (or remove the BecomesStation block if Falcons should not become a
station) so it references the correct station/config for the Falcon instead of
pulling Sabre assets.
In `@Resources/Maps/_Crescent/Shuttles/NAP/phantom.yml`:
- Around line 266-267: В блоке с типом BecomesStation (в файле phantom.yml)
указан id: Nova, из‑за чего карта мапится на конфиг Nova; замените id: Nova на
id: Phantom, чтобы использовался правильный прототип Phantom (т.е. поменять
строку "id: Nova" на "id: Phantom" в той же секции BecomesStation).
In `@Resources/Prototypes/_Crescent/Entities/Objects/Misc/shiplpcs.yml`:
- Around line 2187-2200: Описание ресурса ShipVoucherMojave содержит
неправильный текст про "Imperial Xenovalk-class medical shuttle" — замените
строку description в записи ShipVoucherMojave так, чтобы она корректно описывала
ваучер для ship: Mojave (например: "An LPC fabprint disk loaded with a Mojave.
Has to be redeemed at a shipyard console."). Обновите только поле description в
сущности ShipVoucherMojave, оставив остальную структуру (components, sprite,
price, ship: Mojave) без изменений.
In `@Resources/Prototypes/_Crescent/Maps/Ships/NAP/falcon.yml`:
- Around line 4-7: В описании Falcon удалите тестовую фразу "Are you even
reading this man?" и исправьте строку LOADOUT в
Resources/Prototypes/_Crescent/Maps/Ships/NAP/falcon.yml: замените "LOADOUT: 1x
48mm missile" на корректное обозначение модуля, согласующееся с модулем Arbalest
— например "LOADOUT: 1x Arbalest 95mm missile" (обновите поле description в
файле Falcon чтобы текст был информативным и соответствовал модулю Arbalest).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d73acd36-32fa-47ad-9750-cd76d7470d5d
📒 Files selected for processing (7)
Resources/Maps/_Crescent/Shuttles/NAP/falcon.ymlResources/Maps/_Crescent/Shuttles/NAP/mojave.ymlResources/Maps/_Crescent/Shuttles/NAP/phantom.ymlResources/Prototypes/_Crescent/Entities/Objects/Misc/shiplpcs.ymlResources/Prototypes/_Crescent/Entities/Structures/mothership_consoles.ymlResources/Prototypes/_Crescent/Maps/Ships/NAP/falcon.ymlResources/Prototypes/_Crescent/Maps/Ships/NAP/phantom.yml
| - type: VesselIcon | ||
| iffIcon: | ||
| sprite: _Crescent/ShipIcons/ifficons.rsi | ||
| state: fighter | ||
| - type: BecomesStation | ||
| id: Sabre |
There was a problem hiding this comment.
Falcon всё ещё ссылается на шаблон Sabre.
На этих строках остались копипаст-значения от другого корабля: state: fighter расходится с ultralight в Resources/Prototypes/_Crescent/Maps/Ships/NAP/falcon.yml (Lines 22-25), а BecomesStation id: Sabre подтянет станционный конфиг из Resources/Prototypes/_Crescent/Maps/Ships/NCWL/sabre.yml вместо Falcon.
🔧 Предлагаемая правка
- - type: VesselIcon
- iffIcon:
- sprite: _Crescent/ShipIcons/ifficons.rsi
- state: fighter
- - type: BecomesStation
- id: Sabre
+ - type: VesselIcon
+ iffIcon:
+ sprite: _Crescent/ShipIcons/ifficons.rsi
+ state: ultralight
+ - type: BecomesStation
+ id: Falcon📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - type: VesselIcon | |
| iffIcon: | |
| sprite: _Crescent/ShipIcons/ifficons.rsi | |
| state: fighter | |
| - type: BecomesStation | |
| id: Sabre | |
| - type: VesselIcon | |
| iffIcon: | |
| sprite: _Crescent/ShipIcons/ifficons.rsi | |
| state: ultralight | |
| - type: BecomesStation | |
| id: Falcon |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@Resources/Maps/_Crescent/Shuttles/NAP/falcon.yml` around lines 398 - 403, The
Falcon map entry still contains copy-paste values from Sabre; update the
VesselIcon/iffIcon state from "fighter" to "ultralight" to match the Falcon
prototype and change the BecomesStation id from "Sabre" to "Falcon" (or remove
the BecomesStation block if Falcons should not become a station) so it
references the correct station/config for the Falcon instead of pulling Sabre
assets.
| - type: BecomesStation | ||
| id: Nova |
There was a problem hiding this comment.
Здесь должен быть Phantom, а не Nova.
Сейчас при BecomesStation карта превращается в станцию Nova, поэтому к NAP Phantom применится конфиг из Resources/Prototypes/_Crescent/Maps/Ships/NCWL/nova.yml, а его собственный Resources/Prototypes/_Crescent/Maps/Ships/NAP/phantom.yml останется неиспользованным.
🔧 Предлагаемая правка
- - type: BecomesStation
- id: Nova
+ - type: BecomesStation
+ id: Phantom📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - type: BecomesStation | |
| id: Nova | |
| - type: BecomesStation | |
| id: Phantom |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@Resources/Maps/_Crescent/Shuttles/NAP/phantom.yml` around lines 266 - 267, В
блоке с типом BecomesStation (в файле phantom.yml) указан id: Nova, из‑за чего
карта мапится на конфиг Nova; замените id: Nova на id: Phantom, чтобы
использовался правильный прототип Phantom (т.е. поменять строку "id: Nova" на
"id: Phantom" в той же секции BecomesStation).
| id: ShipVoucherMojave | ||
| name: Nap 'Mojave' pattern LPC fabprint disk | ||
| description: An LPC fabprint disk loaded with an Imperial Xenovalk-class medical shuttle. Has to be redeemed at a shipyard console. | ||
| components: | ||
| - type: Item | ||
| size: Small | ||
| - type: Sprite | ||
| sprite: _Crescent/Objects/Misc/lpcchip.rsi | ||
| layers: | ||
| - state: icon | ||
| - type: StaticPrice | ||
| price: 200000 | ||
| - type: ShipVoucher | ||
| ship: Mojave |
There was a problem hiding this comment.
Исправьте описание ShipVoucherMojave.
Сейчас ваучер для Mojave всё ещё описан как Imperial Xenovalk-class medical shuttle, хотя на Line 2200 он выдаёт ship: Mojave. Это явный копипаст и будет путать игроков в интерфейсе.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@Resources/Prototypes/_Crescent/Entities/Objects/Misc/shiplpcs.yml` around
lines 2187 - 2200, Описание ресурса ShipVoucherMojave содержит неправильный
текст про "Imperial Xenovalk-class medical shuttle" — замените строку
description в записи ShipVoucherMojave так, чтобы она корректно описывала ваучер
для ship: Mojave (например: "An LPC fabprint disk loaded with a Mojave. Has to
be redeemed at a shipyard console."). Обновите только поле description в
сущности ShipVoucherMojave, оставив остальную структуру (components, sprite,
price, ship: Mojave) без изменений.
| description: | | ||
| A sleek American ultra-light strike shuttle, built for fast hit-and-run operations. The Falcon is perfect for flanking attacks. Are you even reading this man? | ||
| LOADOUT: 1x 48mm missile | ||
| MINIMUM CREW: 1x Pilot |
There was a problem hiding this comment.
Исправьте текст описания Falcon.
Фраза Are you even reading this man? выглядит как забытый тестовый текст. Плюс LOADOUT: 1x 48mm missile расходится с картой Resources/Maps/_Crescent/Shuttles/NAP/falcon.yml, где на Line 644 модуль подписан как Arbalest 95mm missile, так что описание сейчас вводит игрока в заблуждение.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@Resources/Prototypes/_Crescent/Maps/Ships/NAP/falcon.yml` around lines 4 - 7,
В описании Falcon удалите тестовую фразу "Are you even reading this man?" и
исправьте строку LOADOUT в
Resources/Prototypes/_Crescent/Maps/Ships/NAP/falcon.yml: замените "LOADOUT: 1x
48mm missile" на корректное обозначение модуля, согласующееся с модулем Arbalest
— например "LOADOUT: 1x Arbalest 95mm missile" (обновите поле description в
файле Falcon чтобы текст был информативным и соответствовал модулю Arbalest).
1 participant
Mojave Mothership Updates
New Ultra-Light Ships:
Phantom
Falcon
Summary by CodeRabbit
Новые возможности