Merged
Conversation
Reviewer's Guide by SourceryThis pull request introduces an HTTP client to the rust-utils library, along with a job system for handling asynchronous requests. It also includes necessary dependency updates and feature flags to manage the new functionality. Class diagram for HTTP and Job SystemclassDiagram
class RequestOptions {
+Option~String~ output_filename
+Option~String~ body_filename
}
class Response {
+u16 status_code
+HashMap~String,String~ headers
+Option~str~ body
}
class RequestPrep {
+Request req
+Option~String~ output_filename
+Vec~u8~ body
}
class Job {
+Receiver~Output~ rx
+JoinHandle handle
}
class Jobs {
+HashMap~JobId,Job~ map
+usize next_job
+start()
+check()
}
Jobs *-- Job
note for Jobs "Manages async HTTP requests"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Furrior
approved these changes
Jan 27, 2025
Furrior
reviewed
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add http client, update dependencies