Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating asset replacer body logic #43

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

leanderiversen
Copy link
Contributor

Implementing the asset replacer changes suggested by @brentrager in #32.

Closes #42.

Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for sst-docs canceled.

Name Link
🔨 Latest commit 4aa449b
🔍 Latest deploy log https://app.netlify.com/sites/sst-docs/deploys/67a32d98f0f36300081825e1

@jayair
Copy link
Contributor

jayair commented Feb 8, 2025

So how does this fix your issue btw?

@leanderiversen
Copy link
Contributor Author

I'm unable to explain the mechanics of the fix, as it was first presented by @brentrager in #32, but it seems like it's relating to timing out somehow. Our deployments can last anywhere from 10 to 25 minutes depending on the environment, but not sure if this is the actual issue, as the Next.js build is what takes the longest.

We have been running the patched version for 3 days at the time of writing, with about 50 deployments and no failures. Others in #32 have also been running their own patched versions successfully, but I cannot explain exactly why it works.

It was initially thought that #34 on its own would fix the issue, but it seems like a combination of the two is required for successful deployments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom::AssetReplacer - socket hang up
2 participants