Fix Chrome import for HttpOnly Slack cookie#108
Open
sudhanshug16 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xoxcteam tokens.dcookie is not visible to page JavaScript.v10/v11cookie values with Chrome Safe Storage, matching the existing Brave importer approach.Fixes the Chrome side of #13.
Why
Recent/current Slack sessions may store
.slack.comcookiedasHttpOnly. In that state, this existing Chrome importer path fails even though the user is logged in and AppleScript JavaScript execution works:I reproduced this on macOS with
agent-slack 0.9.3: the Slack tab exposedlocalConfig_v2with anxoxc-*team token, while Chrome's Cookies DB contained.slack.comcookiedwithis_httponly = 1.Verification
bun run typecheckbun testbun run lintexits 0; existing warnings remain unrelatedbun run format:checkbun run build:npmbun run src/index.ts auth import-chromeimported 1 workspace token from my logged-in Chrome Slack session