Skip to content

fix(runtime): resolve folder workspace file selectors#6363

Open
bennewell35 wants to merge 3 commits into
stablyai:mainfrom
bennewell35:ben/fix-folder-workspace-selector
Open

fix(runtime): resolve folder workspace file selectors#6363
bennewell35 wants to merge 3 commits into
stablyai:mainfrom
bennewell35:ben/fix-folder-workspace-selector

Conversation

@bennewell35

Copy link
Copy Markdown
Contributor

Summary

  • resolve folder workspace selectors for runtime file operations without broadening generic git/worktree selector behavior
  • preserve SSH connection routing for remote folder workspace file reads
  • add local and SSH regression coverage for folder workspace file explorer paths

Addresses the file explorer selector_not_found portion of #6357.

Tests

  • pnpm exec vitest run --config config/vitest.config.ts src/main/runtime/orca-runtime.test.ts -t "reads file explorer paths for a|routes SSH folder workspace file explorer|folder workspace"
  • pnpm exec vitest run --config config/vitest.config.ts src/main/runtime/orca-runtime-files.test.ts src/main/runtime/orca-runtime-files-watch.test.ts
  • pnpm exec oxlint src/main/runtime/orca-runtime.ts src/main/runtime/orca-runtime-files.ts src/main/runtime/orca-runtime.test.ts src/main/runtime/orca-runtime-files.test.ts src/main/runtime/orca-runtime-files-watch.test.ts
  • pnpm run typecheck:node

Copilot AI review requested due to automatic review settings June 25, 2026 13:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3fcf62cc-f1dc-4660-9787-dedd1c6804e0

📥 Commits

Reviewing files that changed from the base of the PR and between 94591f0 and 754542d.

📒 Files selected for processing (4)
  • src/main/runtime/orca-runtime-files-watch.test.ts
  • src/main/runtime/orca-runtime-files.test.ts
  • src/main/runtime/orca-runtime-files.ts
  • src/main/runtime/orca-runtime.ts
💤 Files with no reviewable changes (4)
  • src/main/runtime/orca-runtime-files-watch.test.ts
  • src/main/runtime/orca-runtime-files.test.ts
  • src/main/runtime/orca-runtime.ts
  • src/main/runtime/orca-runtime-files.ts

📝 Walkthrough

Walkthrough

The runtime service now exposes resolveRuntimeFileTarget, which returns a worktree and optional connectionId from folder-workspace scope resolution or worktree lookup. Runtime-file commands, search/list operations, and file-explorer path resolution now consume that target, and the tests update their mocks and coverage.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is missing required template sections like Screenshots, AI Review Report, Security Audit, and Notes. Add the missing template sections and include the requested review, security, and platform-compatibility details, or mark no visual change where applicable.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately describes the main runtime selector fix in this PR.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

nwparker added a commit that referenced this pull request Jun 29, 2026
Folder-workspace selectors can now resolve through the existing folder launch-scope path before falling back to normal worktree resolution. This fixes file explorer read/preview/search/list operations for local and SSH-backed folder workspaces without changing git target resolution.

Refs #6357.
Supersedes #6363.

Co-authored-by: bennewell35 <newelljben@gmail.com>
brennanb2025 and others added 2 commits June 29, 2026 17:53
Co-authored-by: Orca <help@stably.ai>
…ace-selector

# Conflicts:
#	src/main/runtime/orca-runtime-files-watch.test.ts
#	src/main/runtime/orca-runtime-files.test.ts
#	src/main/runtime/orca-runtime-files.ts
#	src/main/runtime/orca-runtime.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants