Fix/6274 ctrl c source mode copy#6365
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe editable-target check now treats Monaco, diff editor, and rich-markdown editor container elements as editable alongside standard form fields and 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…cut guards - Add Monaco/diff/rich-markdown editor roots to the shared editable-target check - Prevent App-level capture handlers from misclassifying Markdown Source mode as non-editable on Windows - Restore native Ctrl+C copy behavior in Monaco-backed editors while preserving terminal xterm exclusions - Add regression coverage for native inputs, Monaco-style editor hosts, and terminal helper textarea handling
- Replace DOM-dependent setup with lightweight HTMLElement mocks - Keep coverage for native inputs, Monaco-style editor hosts, and terminal helper textarea exclusions
Summary
Fixed #6274 the Windows Markdown Source mode copy bug by making Monaco-backed editor surfaces count as editable, so Ctrl+C is no longer intercepted by global shortcut guards.
Screenshots
No visual change
Testing
AI Review Report
Reviewed the shortcut routing path end to end and checked the main risks: global shortcut interception, terminal
exclusions, and cross-platform behavior. Verified the fix is limited to renderer-side editable-target detection and does
not change main-process accelerators, clipboard handling, or IPC flow.
Cross-platform compatibility checked for macOS, Linux, and Windows, including shortcut behavior, labels, path handling,
shell behavior, and Electron-specific shortcut differences.
Security Audit
No security issues found. This change does not add input parsing, command execution, IPC, auth, secrets, or path-handling
risk.
Notes
textarea exclusion.