Skip to content

Fix Windows terminal clear repaint#6382

Open
Jinwoo-H wants to merge 1 commit into
mainfrom
Jinwoo-H/rendering-issues-windows
Open

Fix Windows terminal clear repaint#6382
Jinwoo-H wants to merge 1 commit into
mainfrom
Jinwoo-H/rendering-issues-windows

Conversation

@Jinwoo-H

Copy link
Copy Markdown
Contributor

Summary

  • after terminal clear on local Windows ConPTY, refit and resize the backing PTY to the visible terminal size
  • refresh the xterm viewport immediately and once on the next animation frame to prevent stale wrapped prompt/cursor paint
  • keep the behavior scoped away from SSH and remote runtime PTYs

Testing

  • pnpm exec oxlint src/renderer/src/components/terminal-pane/TerminalPane.tsx
  • pre-commit hooks: oxlint, react-doctor oxlint, oxfmt

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b2fb8dfb-d3a2-42bf-b698-d6b8e6cad27b

📥 Commits

Reviewing files that changed from the base of the PR and between be8ec2a and 9985ffe.

📒 Files selected for processing (1)
  • src/renderer/src/components/terminal-pane/TerminalPane.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/renderer/src/components/terminal-pane/TerminalPane.tsx

📝 Walkthrough

Walkthrough

clearPaneScrollback now clears the active pane’s xterm scrollback and the associated web runtime buffer. For Windows local ConPTY terminals, it also performs an additional safeFit/resize/refresh pass immediately and again on the next animation frame if the pane is still mounted. The callback dependency list now includes worktreeId.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers summary and testing, but it omits required template sections like Screenshots, AI Review Report, Security Audit, and Notes. Add the missing template sections and complete the testing checklist, including screenshots or 'No visual change' and the required AI review and security audit notes.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main user-visible change in the PR.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 243dd325-2b42-4348-b114-97e8475b90ef

📥 Commits

Reviewing files that changed from the base of the PR and between c10b77d and f6eb937.

📒 Files selected for processing (1)
  • src/renderer/src/components/terminal-pane/TerminalPane.tsx

Comment thread src/renderer/src/components/terminal-pane/TerminalPane.tsx Outdated
@Jinwoo-H Jinwoo-H force-pushed the Jinwoo-H/rendering-issues-windows branch from f6eb937 to be8ec2a Compare June 25, 2026 20:29
@Jinwoo-H Jinwoo-H force-pushed the Jinwoo-H/rendering-issues-windows branch from be8ec2a to 9985ffe Compare June 26, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant