fix: use broader iterable type #1614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1614 +/- ##
=======================================
Coverage 92.22% 92.22%
=======================================
Files 55 55
Lines 8411 8414 +3
Branches 973 973
=======================================
+ Hits 7757 7760 +3
Misses 466 466
Partials 188 188 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jsignell
requested changes
Dec 29, 2025
Member
jsignell
left a comment
jsignell
left a comment
There was a problem hiding this comment.
As mentioned below, the type changes are good, but I think changing the positional arg names seems unnecessary since it's breaking.
The constructor is an instance method, not a class method, so call the first parameter "self".
The variable is mutable so the type is invariant, use the Iterable type that it is declared as in the superclass.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Use
selfas name for the first parameter for instance methods, and align type annotations to match the superclass type annotation for mutable variables.PR Checklist:
pre-commit run --all-files)pytest)