Skip to content

Add support for Patch endpoints #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 74 commits into
base: main
Choose a base branch
from
Open

Add support for Patch endpoints #291

wants to merge 74 commits into from

Conversation

rhysrevans3
Copy link
Collaborator

@rhysrevans3 rhysrevans3 commented Aug 29, 2024 •
edited
Loading

Description:
Adds PATCH endpoints to transaction extension. Adds support for RFC 6902 and RFC 7396. Pivots on header Content-Type value.

Related pull requests:

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable
  • Changes are added to the changelog

@rhysrevans3
Adding patch endpoints to transactions extension to elasticsearch.
e0bd94f
@rhysrevans3
Adding patch to opensearch backend.
01c1563
@rhysrevans3
Pinning to pull request version for tests.
d171c24
@rhysrevans3
Merge branch 'main' of github.com:stac-utils/stac-fastapi-elasticsear…
59661c5 
…ch into patch_endpoints
@rhysrevans3
Updating patch types.
5400e42
@rhysrevans3
Adding checks for existing properties.
fe8530a
@rhysrevans3
Updating utils.
7cf36eb
@rhysrevans3
Adding model for path.
5929b00
@rhysrevans3
Switch to use pydantic model for operation path.
d94d8fe
@rhysrevans3
Merge branch 'main' of github.com:stac-utils/stac-fastapi-elasticsear…
4623a43 
…ch into patch_endpoints
@rhysrevans3
Adding computed_field output type.
093c593
@rhysrevans3
pre-commit.
d4bd07a
@rhysrevans3
Add changes to opensearch.
b6b0721
@rhysrevans3
pre-commit.
90a287f
@rhysrevans3
Switch to model validator.
f1c320a
@rhysrevans3
Simplify conversion logic.
a2d6f48
@rhysrevans3
Opensearch update body not script.
3a75b68
@rhysrevans3
pre-commit.
ee90324
@rhysrevans3
Remove duplicate test name.
173ef0d
@rhysrevans3
PatchOperation not dict for tests.
93350c7
@rhysrevans3
pre-commit.
bf6f96a
@rhysrevans3
filter_expr not filter for aggregation request.
29f6e2e
@rhysrevans3
pre-commit.
3d5b168
@rhysrevans3
Filter fix.
ca64ba3
@rhysrevans3
remove PatchOperation in tests.
b412576
@rhysrevans3
patch bugs.
7368d8d
@rhysrevans3
Switch to http exception.
2b359f6
@rhysrevans3
test_item_search_temporal_window_get fix.
0274b64
@rhysrevans3
Request not BadRequest for opensearch.
1c4fe43
@rhysrevans3
Opensearch update body.
fb6fe82
rhysrevans3 added 25 commits May 28, 2025 11:49
@rhysrevans3
Updating es path regex.
a34e881
@rhysrevans3
Patch regex error.
4666f9e
@rhysrevans3
use params for script.
0b86ab3
@rhysrevans3
Remove json dump for param values.
6905919
@rhysrevans3
Refresh after id changes.
c720ac3
@rhysrevans3
Adding missing test params.
b0ecbca
@rhysrevans3
Fix tests.
f93bc3b
@rhysrevans3
Merge branch 'main' of github.com:stac-utils/stac-fastapi-elasticsear…
922f552 
…ch into patch_endpoints
@rhysrevans3
Updating stac_pydantic for core.
3cf4997
@rhysrevans3
Removing datetime from core search.
dcb9fb0
@rhysrevans3
Adding timezone to test collection.
502da27
@rhysrevans3
Merge branch 'main' of github.com:stac-utils/stac-fastapi-elasticsear…
3bcd739 
…ch into patch_endpoints
@rhysrevans3
fix len miss match.
11b94e3
@rhysrevans3
Patch test path correction.
24b319b
@rhysrevans3
Remove bad operations.
dc9db54
@rhysrevans3
Move op test.
f93c04c
@rhysrevans3
pre-commit.
968be95
@rhysrevans3
Opensearch use body for script update.
9ca04ef
@rhysrevans3
patch operations test.
92611a7
@rhysrevans3
collection json patch just add.
530eba7
@rhysrevans3
Json patch replace.
5393405
@rhysrevans3
move in collection.
49b80b2
@rhysrevans3
copy operation.
26cdde8
@rhysrevans3
No nest bug fix.
66ea717
@rhysrevans3
Merge branch 'main' of github.com:stac-utils/stac-fastapi-elasticsear…
3dd27aa 
…ch into patch_endpoints
@rhysrevans3 rhysrevans3 marked this pull request as ready for review June 11, 2025 09:21
@rhysrevans3
Copy link
Collaborator Author

@jonhealy1 this is ready for review but is pinned to a pull request for stac-fastapi we'll have to wait for the next release if we want to avoid that.

@rhysrevans3 rhysrevans3 requested a review from jonhealy1 June 11, 2025 09:59
@jonhealy1
Copy link
Collaborator

@rhysrevans3 Adding patch endpoints is pretty epic.

@jonhealy1
Copy link
Collaborator

jonhealy1 commented Jun 11, 2025 •
edited
Loading

One thing to note. Anything elasticsearch-related from core needs to be moved to sfeos_helpers now. Sorry for doing this in the middle of this work. Core now is only for code that is database-agnostic and may be useful for other databases besides for just es/os.

Some of the shared code from database_logic in elasticsearch and opensearch could also theoretically be moved to sfeos_helpers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonhealy1 jonhealy1

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rhysrevans3 @jonhealy1