fix: Revert "feat: custom version for NiFi (#1172)"

[sbernauer]

Description

Part of stackabletech/nifi-operator#814.

This reverts commit a187657 from #1172

This caused problems (see the linked issue), so we are going to revert it for now to get tests green. We can always re-add it once we fixed the Python client problem or decide to ship it anyway.

CC @dervoeti

Definition of Done Checklist

Note

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.

Please make sure all these things are done and tick the boxes

• Changes are OpenShift compatible
• All added packages (via microdnf or otherwise) have a comment on why they are added
• Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
• All packages should have (if available) signatures/hashes verified
• Add an entry to the CHANGELOG.md file
• Integration tests ran successfully

TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

[lfrancke]

I said I wanted to look at it first and I haven't had the time. Please don't merge yet.

[sbernauer]

Sure, but we really need the decision pls. We (four people, including release team) decided to for now revert it for until we have a decision. It takes seconds to add back in. We have so many problems that prevent tests from getting green, that it's hard enough even without this ;)

[NickLarsenNZ]

Just to add, we thought it was best not to wait and that you (@lfrancke) can always make your decision and we can revert it if necessary.

It would be nice not to break things for customers/users who rely on the python nifi client.

Are you able to give an ETA on that?

[NickLarsenNZ]

LGTM

Approving so it isn't stuck (if Lars decides it should happen).

[sbernauer]

We can close this, we are working an a solution in e.g. #1205