Backport NIFI-14858 to NiFi 2.4.0#1225
Merged
Merged
Conversation
bc08801 to
b5719dc
Compare
b5719dc to
9ff6251
Compare
This was referenced Aug 13, 2025
Member
|
nit: I think we should remove the "Backport" from the PR title, no that the chances of it getting merged are very small |
maltesander
approved these changes
Aug 15, 2025
Member
maltesander
left a comment
There was a problem hiding this comment.
LGTM!
I dont feel this will be fixed upstream so i would rename the PR and changelog entry as @sbernauer suggested and merge?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This allows to manually work around stackabletech/nifi-operator#812 by applying NIFI-14848 to NiFi 2.4.0.
It allows disabling of SNI checks for NiFi 2.x
How this was tested
I did run the image build and we tested it manually on a cluster with an Ingress.
Without config overrides we'd get an error accessing NiFi.
With the config overrides it works:
Definition of Done Checklist
Note
Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.
Please make sure all these things are done and tick the boxes
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
baketo retrieve the image tag for<image-tagged-with-the-major-version>.