Skip to content

Conversation

Maleware
Copy link
Member

@Maleware Maleware commented May 5, 2025

Description

Part of #704

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@Maleware Maleware self-assigned this May 5, 2025
@soenkeliebau
Copy link
Member

Is this ready for review @Maleware ? I don't think you requested one yet..

@Maleware
Copy link
Member Author

Yes and no.

It's the only working solution, but it will break stuff. I'd talk about it today to see if we want to make the efforts to fix it or leave as is. Depending on this, we can merge it or document a better way.

@Maleware
Copy link
Member Author

needs to wait for https://github.com/stackabletech/decisions/issues/54 as this changes the regex expression

@Maleware Maleware moved this to Development: Waiting for Review in Stackable Engineering Jun 11, 2025
@Maleware Maleware requested a review from a team June 11, 2025 13:09
@soenkeliebau soenkeliebau moved this from Development: Waiting for Review to Development: Track in Stackable Engineering Jun 16, 2025
@Maleware
Copy link
Member Author

after talking to @adwk67 we are not waiting on the decision of the service name. We will merge with the current implementation ( It's already with listener ) and rework if needed.

Moving to ready for review.

@Maleware Maleware moved this from Development: Track to Development: Waiting for Review in Stackable Engineering Jun 17, 2025
@razvan razvan moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 17, 2025
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Maleware Maleware added this pull request to the merge queue Jun 24, 2025
Merged via the queue into main with commit 791d835 Jun 24, 2025
17 checks passed
@Maleware Maleware deleted the fix/nifi2.0.0-monitoring-docs branch June 24, 2025 12:20
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Jun 30, 2025
@lfrancke
Copy link
Member

Can you please link to the generated docs?

@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Jun 30, 2025
@Maleware
Copy link
Member Author

Maleware commented Jul 7, 2025

@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants