-
-
Notifications
You must be signed in to change notification settings - Fork 7
Adding docs on how to authenticate with prometheus to nifi 2.x.x metrics #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ackabletech/nifi-operator into fix/nifi2.0.0-monitoring-docs
Is this ready for review @Maleware ? I don't think you requested one yet.. |
Yes and no. It's the only working solution, but it will break stuff. I'd talk about it today to see if we want to make the efforts to fix it or leave as is. Depending on this, we can merge it or document a better way. |
needs to wait for https://github.com/stackabletech/decisions/issues/54 as this changes the regex expression |
after talking to @adwk67 we are not waiting on the decision of the service name. We will merge with the current implementation ( It's already with listener ) and rework if needed. Moving to |
…ackabletech/nifi-operator into fix/nifi2.0.0-monitoring-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Can you please link to the generated docs? |
Description
Part of #704
Definition of Done Checklist