Skip to content

Support custom NiFi components via git-sync#793

Merged
siegfriedweber merged 30 commits into
mainfrom
feat/custom-processors
May 30, 2025
Merged

Support custom NiFi components via git-sync#793
siegfriedweber merged 30 commits into
mainfrom
feat/custom-processors

Conversation

@siegfriedweber

@siegfriedweber siegfriedweber commented May 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Support custom Python processors via git-sync

Closes #739

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
    • stackabletech/decisions#52
    • stackabletech/decisions#53
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Roadmap has been updated

@siegfriedweber siegfriedweber self-assigned this May 8, 2025
This was referenced May 7, 2025
Closed
Merged
@siegfriedweber siegfriedweber added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 16, 2025
@siegfriedweber siegfriedweber mentioned this pull request May 22, 2025
Closed
15 tasks
NickLarsenNZ
NickLarsenNZ reviewed May 23, 2025
View reviewed changes

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving some comments about external error sources before closing #798

Comment thread rust/operator-binary/src/crd/authentication.rs Outdated
Comment thread rust/operator-binary/src/security/authentication.rs Outdated
Comment thread rust/operator-binary/src/security/oidc.rs Outdated
Comment thread rust/operator-binary/src/main.rs
@NickLarsenNZ NickLarsenNZ mentioned this pull request May 23, 2025
Closed
76 tasks
@siegfriedweber siegfriedweber marked this pull request as ready for review May 27, 2025 13:22
@siegfriedweber siegfriedweber requested a review from a team May 27, 2025 13:22
@siegfriedweber siegfriedweber moved this to Development: Waiting for Review in Stackable Engineering May 27, 2025
@sbernauer sbernauer changed the title Support custom Python processors via git-sync Support custom NiFi components via git-sync May 27, 2025
@siegfriedweber

siegfriedweber commented May 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

✅ https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/nifi-operator-it-custom/51/

@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering May 30, 2025
NickLarsenNZ
NickLarsenNZ approved these changes May 30, 2025
View reviewed changes

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siegfriedweber siegfriedweber added this pull request to the merge queue May 30, 2025
Merged via the queue into main with commit aa08d1f May 30, 2025
16 of 17 checks passed
@siegfriedweber siegfriedweber deleted the feat/custom-processors branch May 30, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@siegfriedweber siegfriedweber

Labels

release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support custom NiFi components via git-sync

2 participants

@siegfriedweber @NickLarsenNZ