Skip to content

Fix and document changing sensitive properties algorithm #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 28, 2025

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented May 23, 2025

Description

fixes #791

  • move sensitive properties CRD to own module
  • check for deprecated algorithms in NiFi 1.x.x and emit warning
  • check for unsupported algorithms in NiFi 2.x.x and error out if used
  • fix setting nifi.flow.configuration.json.file in NiFi 1.x.x which stopped CLI tools from working
  • documented step by step how to update the algorithms

Test script with a couple of commands:
test-nifi-sensitive-properties.sh.tar.gz

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases test script available
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Roadmap has been updated

@maltesander maltesander requested a review from a team May 23, 2025 14:20
@maltesander maltesander self-assigned this May 23, 2025
@maltesander maltesander marked this pull request as ready for review May 23, 2025 14:50
@adwk67 adwk67 requested review from adwk67 and removed request for a team May 27, 2025 15:30
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor things.

Co-authored-by: Andrew Kenworthy <[email protected]>
@maltesander maltesander enabled auto-merge May 28, 2025 11:05
@maltesander maltesander added this pull request to the merge queue May 28, 2025
Merged via the queue into main with commit 97154f3 May 28, 2025
16 of 17 checks passed
@maltesander maltesander deleted the feat/check-sensitive-prop-algorithm-for-version branch May 28, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NiFi 2.x removes support for deprecated encryption methods
2 participants